Fix sharing and around three errors related to Undefined array key "CLOUD" #40208
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LOUD" We try to access $contact['CLOUD'] when it might not be set. As a consequence of that 3 PHP errors are generated the last one being an uncaught exception that makes it impossible to share files locally. This patch adds a simple check to ensure the value exists before using it. Signed-off-by: Francisco Blas Izquierdo Riera (klondike) <klondi@users.noreply.github.com>
|
For more details this seems to be triggered by the LDAP Contacts Backend as the contacts returned do not (for obvious reasons) have a CLOUD parameter. |
|
Is this associated with an open Issue? |
tcitworld
reviewed
Sep 5, 2023
| @@ -186,7 +186,7 @@ public function search($search, $limit, $offset, ISearchResult $searchResult) { | |||
| return false; | |||
| } | |||
|
|
|||
| if ($this->shareeEnumeration) { | |||
| if ($this->shareeEnumeration && isset($contact['CLOUD'])) { | |||
There was a problem hiding this comment.
nitpick: Please add the check on the condition line 164 as well.
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
added
2. developing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We try to access $contact['CLOUD'] when it might not be set. As a consequence of that 3 PHP errors are generated the last one being an uncaught exception that makes it impossible to share files locally.
This patch adds a simple check to ensure the value exists before using it.
Please backport this to stable 26 too as it also has the same issue.
Checklist